feat(alert-dialog): fix role #746
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The role="generic" was added to the ToastNotification with the aim of making the NotificationSystem role="alert" work. However, we have decided not to use role="alert" anymore and use ScreenReaderAnnouncer instaed.
After speaking with the A11y team on Office Hours, and reading the A11y documentation online, the correct role for the Toast Notification is "alertdialog" if it has interactive buttons inside. If it doesn't, the documentation says the right role should be "alert", but as we have decided not to use this, I am keeping the role="generic" and adding "aria-hidden"=true.
This work will complement work on SPARK-598178 of adding SRAnnouncements to the NotificationSystem for SR to automatically announce any new toast that appears on the screen.
Links
Links to relevent resources.